Skip to content

Fix docstring nits - #3758

Merged
zcbenz merged 1 commit into
ml-explore:mainfrom
ishtihoss:fix-doc-nits
Jun 28, 2026
Merged

Fix docstring nits#3758
zcbenz merged 1 commit into
ml-explore:mainfrom
ishtihoss:fix-doc-nits

Conversation

@ishtihoss

@ishtihoss ishtihoss commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • fix the margin_ranking_loss example output for the default reduction='none'
  • fix the Bilinear docstring formula and weight shape order

Tests

  • /Users/porkr/projects/contributor/.venv/bin/black --check python/mlx/nn/losses.py python/mlx/nn/layers/linear.py
  • PYTHONPATH=python:python/tests /Users/porkr/projects/contributor/.venv/bin/python -m unittest python.tests.test_losses.TestLosses.test_margin_ranking_loss python.tests.test_nn.TestLayers.test_bilinear -v

zcbenz
zcbenz reviewed Jun 24, 2026
View reviewed changes
Comment thread python/mlx/nn/layers/linear.py Resolved
zcbenz
zcbenz approved these changes Jun 24, 2026
View reviewed changes

@zcbenz zcbenz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zcbenz zcbenz mentioned this pull request Jun 27, 2026
Closed
3 tasks done
@zcbenz
zcbenz merged commit ca60290 into ml-explore:main Jun 28, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ishtihoss @zcbenz