Repository navigation
Fix dimension count in orthogonal initializer error message - #3693
Merged
zcbenz merged 1 commit intoJun 16, 2026
Merged
Conversation
The error raised for a non-2D input concatenated a plain string holding
{a.ndim} onto an f-string, so the message printed the literal text
instead of the array's dimension count. Move the interpolation onto the
f-string and add a test asserting the reported dimension.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error raised by
nn.init.orthogonalfor a non-2D input never reported the actual number of dimensions. The message was split across two string literals where only the first carried thefprefix:The
{a.ndim}lives on the plain (non-f) string, so it was printed verbatim:Moving the
fprefix onto the segment that contains the placeholder fixes the interpolation:Added an assertion to
test_orthogonalthat a 3D input reports3D arrayin the message.