Repository navigation
Fix tree_map_with_path for namedtuples - #3674
Conversation
|
Added one more regression in Verification:
|
|
Your text is not very readable. |
243b1c9 to
1948966
Compare
|
Thanks, agreed. I cleaned up the PR description so it renders as normal Markdown sections instead of escaped newline text, and kept the test notes concise. |
You can disable metal backend when building. |
|
Thanks, that worked. I rebuilt this PR branch with Metal disabled and reran the requested test successfully. Commands/results: CMAKE_ARGS="-DMLX_BUILD_METAL=OFF" CMAKE_BUILD_PARALLEL_LEVEL=4 \
/Users/chris.s/.pyenv/versions/3.11.7/bin/python -m pip install -e .
# Successfully installed mlx-0.32.0.dev20260614+19489666
/Users/chris.s/.pyenv/versions/3.11.7/bin/python -m pytest python/tests/test_tree.py -q
# 4 passed in 0.25s
/Users/chris.s/.pyenv/versions/3.11.7/bin/python -m pytest python/tests/test_utils_pyonly.py -q
# 1 passed in 0.03sI also confirmed the rebuilt extension is the local PR build and Metal is disabled: mlx /Users/chris.s/conductor/workspaces/ml-ide/caracas/.codex_tmp/mlx-pr3674/python/mlx/core.cpython-311-darwin.so
metal available False |
|
|
|
Removed it. The PR diff is now only:
Re-ran after the cleanup: /Users/chris.s/.pyenv/versions/3.11.7/bin/python -m pytest python/tests/test_tree.py -q
# 4 passed in 0.30s |
Summary
tree_map_with_path, matchingtree_mapbehavior.tree_map_with_pathpaths, return type, and rest-argument mapping.Tests
python -m unittest discover python/tests -p 'test_utils_pyonly.py' -vpython -m pytest python/tests/test_utils_pyonly.py -qgit diff --check upstream/main...HEADNot run locally
python -m pytest python/tests/test_tree.py -qblocked before collection in this headless session:RuntimeError: [metal::load_device] No Metal device available