Repository navigation
Fix axis param in nll_loss - #3651
Merged
Merged
Conversation
ishtihoss
force-pushed
the
fix-nll-loss-axis
branch
from
June 10, 2026 22:07
d779b41 to
2d87931
Compare
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
nll_lossignores itsaxisargument. The gather happens alongaxisbut the targets get expanded at the last dim and the result squeezed at the last dim, so anything other than the default axis either fails with a confusing squeeze error, or returns wrong values with no error at all if the trailing dim happens to be 1:cross_entropy had the same problem and was fixed in #2641, but nll_loss kept the old pattern. This applies the same fix and adds a test along the lines of the one from that PR. Checked the result against numpy take_along_axis for axis 0, a middle axis on a 3d input, and the default axis.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes