Repository navigation
Correct grammatical typo in label smoothing ValueError - #3641
Merged
Merged
Conversation
Correct a grammatical typo in the ValueError message raised when label_smoothing is out of range in cross_entropy. Changes "must in [0, 1)" to "must be in [0, 1)" to improve clarity (python/mlx/nn/losses.py).
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes a minor grammatical typo in the ValueError message raised when the label_smoothing parameter in cross_entropy is out of the valid [0, 1) range.
Before: "Label smoothing must in [0, 1), got {label_smoothing}."
After: "Label smoothing must be in [0, 1), got {label_smoothing}."
While simple, error messages are a primary interface for developers using MLX. Grammatically correct and clear error messages:
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes