Repository navigation
Fix CUDA all-reduce planning for large inputs - #3603
Merged
Merged
Conversation
zcbenz
approved these changes
May 29, 2026
zcbenz
left a comment
zcbenz
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this! I'm good without a test since it is going to require allocating a very large buffer.
sofinvalery
force-pushed
the
fix-all-reduce
branch
from
May 29, 2026 10:50
1b8ea97 to
c380285
Compare
megacpp
pushed a commit
to DatasunriseOU/mlx
that referenced
this pull request
Jun 3, 2026
(cherry picked from commit 790be8a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3602.
Not sure if I should add a test.