Repository navigation
Add copy keyword to mx.asarray - #3510
Merged
Merged
Conversation
zcbenz
requested changes
May 11, 2026
zcbenz
left a comment
zcbenz
left a comment
Member
There was a problem hiding this comment.
The copy parameter only makes sense if the framework supports in-place operation and you want to make a deep copy whose content would stay unchanged when the original copied array got an in-place update. But since MLX has no in-place operation and the supposed use case would never happen.
So I think the best way to support copy parameter is to simply throw when copy=False is passed and return create_array(a, dtype) otherwise like before. Because copy=False means shallow-copy which makes no sense in MLX, and code using copy=True|None would stay semantically correct.
eyupcanakman
force-pushed
the
fix/asarray-copy-kwarg-3484
branch
from
May 12, 2026 16:19
074ec2b to
7e60107
Compare
Contributor
Author
|
Makes sense, reworked it that way: |
This comment was marked as low quality.
This comment was marked as low quality.
4 tasks done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
mx.asarraydoesn't accept thecopykeyword from the array-API spec. References #3484.This adds
copyas a keyword-only argument. MLX has no in-place operations, so a non-copying conversion isn't meaningful:copy=FalseraisesValueError, andcopy=Trueor unspecified behave the same as before.The
from_dlpackhalf of #3484 is left out, since PR #3495 reworks dlpack consumption through themx.array(...)constructor and the namespace wiring depends on that landing.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes