Repository navigation
Update nanobind version to v2.12.0 - #3396
Merged
Merged
Conversation
zcbenz
approved these changes
Apr 12, 2026
zcbenz
left a comment
zcbenz
left a comment
Member
There was a problem hiding this comment.
Thanks!
Having the examples using the pinned version is usually the safe choice.
Contributor
Author
|
Ok. Ready to merge ... @zcbenz I don't think that I have permission to merge. |
1 task done
Contributor
Author
|
We now seem to be on nanobind 2.14. The runtime changes—especially integer conversion semantics and reference-count fixes—mean MLX itself should run its complete build/test suite before changing its CMake pin, but it seems to be a mainly bug fix improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
See #3392 Some of the examples pull in nanobind 2.10.2. Not sure whether they should be changed to lower bound constraints or pinned, as they currently are, like here.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes