Repository navigation
Avoid joining threads on exit - #3388
Merged
Merged
Conversation
zcbenz
force-pushed
the
fix-windows-tests
branch
4 times, most recently
from
April 10, 2026 06:06
7ea314a to
3ae07b6
Compare
zcbenz
force-pushed
the
fix-windows-tests
branch
from
April 10, 2026 06:34
3ae07b6 to
33c8ba0
Compare
angeloskath
approved these changes
Apr 10, 2026
angeloskath
left a comment
angeloskath
left a comment
Member
There was a problem hiding this comment.
Looks great, left a tiny comment.
| #include <mutex> | ||
| #include <stdexcept> | ||
| #include <string> | ||
| #include <thread> |
Member
Author
There was a problem hiding this comment.
This file implicitly included the thread via device.h => worker.h, which this PR removes from device.h's includes.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows there is a bug that joining threads on exit would end up with deadlock, and we can't just leak the threads in
CommandEncoderbecause they are thread local and it would be real leaks.So instead of joining the threads in the destructor, we detach the threads and let them delete themselves once the threads finish working.