Skip to content

Fix test "test get streams" missing initialization - #3376

Merged
zcbenz merged 1 commit into
ml-explore:mainfrom
dseredkin:fix-test-get-streams
Apr 8, 2026
Merged

zcbenz merged 1 commit into
ml-explore:mainfrom
dseredkin:fix-test-get-streams

Conversation

@dseredkin

Copy link
Copy Markdown
Contributor

The test "test get streams" assumes get_streams() would return at least the default CPU stream without any initialisation. This seems to be true before df7f7db, which removed initialization from Scheduler's constructor.

The failure can be reproduced by running the test in isolation:
./build/tests/tests --test-case="test get streams"

Fix by calling default_stream(Device::cpu) before get_streams() to match the test expectation.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@zcbenz zcbenz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@zcbenz
zcbenz merged commit 8332e22 into ml-explore:main Apr 8, 2026
16 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 22, 2026
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants