Repository navigation
[CUDA] Thread safety - #3367
Merged
Merged
[CUDA] Thread safety#3367
Conversation
angeloskath
reviewed
Apr 4, 2026
angeloskath
left a comment
angeloskath
left a comment
Member
There was a problem hiding this comment.
Shouldn't the cudnn and cublas handles also be thread local? I think the docs say the libraries are only thread safe if each thread has their own handle.
zcbenz
force-pushed
the
encoder-refactor-5
branch
from
April 5, 2026 02:08
e00ae11 to
854c025
Compare
Member
Author
|
Yeah you are right, somehow I remembered it the opposite way. The cudnn/cublas handles are now thread local and destroyed on thread teardown. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3078.
These are the thread safety changes for CUDA backend, which basically do the same thing with the Metal backend:
cu::Deviceto avoid using locks for multi-thread environment.