Repository navigation
Manage Metal objects with smart pointers - #3282
Merged
Merged
Conversation
angeloskath
approved these changes
Mar 24, 2026
angeloskath
left a comment
angeloskath
left a comment
Member
There was a problem hiding this comment.
Looks great! Thanks for doing that. It is so much better than before actually...
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3148.
For resources that are going to be transferred or kept, store them in
NS::SharePtr, for temporary resources useautorelease(). In this way we don't have to manually callrelease(), which made the code very hard to modify, and it also makes the code exception-safe when we want to handle errors.Have ran tests with
OBJC_DEBUG_MISSING_POOLS=YESand verified that we are not adding leaks. And the impact of this change is actually small since most resources are only created once on initialization and not released on exit.