Repository navigation
Remove quantized_utils.cuh - #3237
Merged
Merged
Conversation
nastya236
self-requested a review
March 10, 2026 10:46
Collaborator
|
Looks great, thank you for doing this! It makes a lot of sense to move dispatch to a file related to affine quantization. |
nastya236
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer really need a
quantized_utils.cuhafter removing the__nv_fp8classes in #3212:get_pack_factor/get_bytes_per_packtobackend/common/quantized.h: share the code between CPU and CUDA backends.dispatch_groups/dispatch_bitstoquantized/affine_quantize.cu: there are several QMM kernels in CUDA backend optimized for different quantizations so each kernel has their own version ofdispatch_groups.absmax_x2toquantized/fp_quantize.cu: it is only used there.