Repository navigation
Enable passing in a GPU architecture string via env var - #3176
Merged
Merged
Conversation
jagrit06
approved these changes
Feb 27, 2026
jagrit06
left a comment
jagrit06
left a comment
Member
There was a problem hiding this comment.
Looks good! Should work as expected on the gemm kernels
andresy
reviewed
Feb 27, 2026
|
|
||
| inline const std::string& metal_gpu_arch() { | ||
| static std::string gpu_arch_ = get_var("MLX_METAL_GPU_ARCH", ""); | ||
| return gpu_arch_; |
Member
There was a problem hiding this comment.
Wondering if some sanity checks should be done here? E.g., we use .back() on the arch name in a number of places...
Member
Author
There was a problem hiding this comment.
Oops overzealous merging.
Well there is the assumption that device_->architecture()->name()->utf8String() can't be the empty string. Given that the PR fixes the error of accessing positions -3 and -2 and also assuming these were in 0-9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tend to use this string for routing to kernels and so on and it can be helpful to test different pathways quickly. See for instance with or without NAX and so on.