Repository navigation
feat: adding the hamming function - #3135
Merged
Merged
Conversation
angeloskath
approved these changes
Feb 17, 2026
angeloskath
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks!
In the future feel free to merge all these into 1 PR since they are addressing the same topic and are fairly small additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the addition of
hanning, this PR implements the Hamming window function (mlx.core.hamming). This further improves parity with NumPy's signal processing tools (numpy.hamming).Implementation Details
hamminginmlx/ops.cpp.2π / (M-1)is pre-calculated as a scalar on the CPU before graph construction. This reduces the number of operations in the compute graph compared to a naive implementation.M < 1(empty) andM = 1(returns[1.0]) explicitly to avoid division by zero.nanobindwith explicit type signature (nb::sig) and full documentation inpython/src/ops.cpp.Test Plan
Verified locally against NumPy for numerical accuracy.
Verification script:
Unit Tests:
Added test_hamming in
python/tests/test_ops.pycovering standard cases, M=1, and M=0.Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes