Repository navigation
Fix donation in sdpa vector - #3121
Merged
Merged
Conversation
This was referenced Aug 9, 2026
rabbitson87
pushed a commit
to rabbitson87/mlx
that referenced
this pull request
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sneaky bug that would only show up when vector sdpa would donate the queries to the input and also be large enough to warrant a command encoder commit.
The bug is that arrays registered as temporaries should not span command encoders because they are removed from the list of outputs we keep track of.
I also deleted a few outdated checks for donation because they are pointless since we changed moving the buffer to copying it.
Fixes the issue in ml-explore/mlx-lm#868 .