Repository navigation
Split broadcast so it is always fused in compile - #2318
Merged
Merged
Conversation
Member
|
That's a very elegant solution.. I didn't think of it. |
1 task
faisalmemon
pushed a commit
to faisalmemon/mlx
that referenced
this pull request
Oct 30, 2025
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does becomes clear with an example. For the following function
the compiled graph changes as follows
Benchmarking on transformer training the speedup is consistent but minimal (~3%-4%) across M2, M2 Ultra and A100.
Splitting broadcast is safe because it is in principle a noop, but we could consider splitting some copies (astype) and redoing them if it will allow us to fuse more things.
@awni I tried to think if there is a possibility of messing up the graph but I think it is ok since to split a broadcast means we certainly are going to produce a fused primitive.