Skip to content

Commit d3bc6a9

Browse files
authored
don't test when doing release (#2734)
1 parent 26ceb50 commit d3bc6a9

3 files changed

Lines changed: 14 additions & 12 deletions

File tree

‎.github/actions/build-macos/action.yml‎

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ inputs:
1414
description: 'Whether to run tests'
1515
required: false
1616
default: 'true'
17-
build-jit:
18-
description: 'Whether to build with JIT'
19-
required: false
20-
default: 'true'
2117

2218
runs:
2319
using: "composite"
@@ -28,9 +24,8 @@ runs:
2824
DEBUG: 1
2925
DEV_RELEASE: 1
3026
run: |
31-
uv pip install --upgrade pip cmake setuptools
32-
uv pip install nanobind==2.4.0 \
33-
numpy torch tensorflow unittest-xml-reporting
27+
uv pip install --upgrade pip
28+
uv pip install cmake setuptools nanobind==2.4.0
3429
uv pip install -e . -v
3530
3631
- name: Generate package stubs
@@ -39,6 +34,12 @@ runs:
3934
uv pip install typing_extensions
4035
uv run --no-project setup.py generate_stubs
4136
37+
- name: Install tests dependencies
38+
if: inputs.run-tests == 'true'
39+
shell: sh
40+
run: |
41+
uv pip install numpy torch tensorflow unittest-xml-reporting
42+
4243
- name: Run Python tests
4344
if: inputs.run-tests == 'true'
4445
shell: bash
@@ -61,7 +62,7 @@ runs:
6162
uv run --no-project test.py
6263
6364
- name: Build CPP only
64-
if: inputs.build-type == 'debug'
65+
if: inputs.run-tests == 'true'
6566
shell: bash
6667
run: |
6768
mkdir -p build
@@ -70,7 +71,7 @@ runs:
7071
make -j $(sysctl -n hw.ncpu)
7172
7273
- name: Run CPP tests
73-
if: ${{ inputs.build-type == 'debug' && inputs.run-tests == 'true' }}
74+
if: inputs.run-tests == 'true'
7475
shell: bash
7576
env:
7677
DEVICE: gpu
@@ -79,7 +80,7 @@ runs:
7980
run: ./build/tests/tests
8081

8182
- name: Build small binary with JIT
82-
if: inputs.build-jit == 'true'
83+
if: inputs.run-tests == 'true'
8384
shell: bash
8485
run: |
8586
mkdir -p build
@@ -93,7 +94,7 @@ runs:
9394
make -j $(sysctl -n hw.ncpu)
9495
9596
- name: Run Python tests with JIT
96-
if: ${{ inputs.build-jit == 'true' && inputs.run-tests == 'true' }}
97+
if: inputs.run-tests == 'true'
9798
shell: bash
9899
env:
99100
LOW_MEMORY: 1

‎.github/workflows/nightly.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
if: github.repository == 'ml-explore/mlx'
5454
strategy:
5555
matrix:
56-
python-version: ["3.10", "3.14"]
56+
python-version: ["3.10", "3.13"]
5757
env:
5858
MACOSX_DEPLOYMENT_TARGET: "15.0"
5959
runs-on: [self-hosted, macos]

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ jobs:
8585
- uses: ./.github/actions/build-macos
8686
with:
8787
build-type: release
88+
run-tests: false
8889
- name: Upload MLX artifacts
8990
uses: actions/upload-artifact@v5
9091
with:

0 commit comments

Comments
 (0)