refactor: Backup anchors without hrefs, for compatibility with autorefs' Markdown anchors#651
Merged
refactor: Backup anchors without hrefs, for compatibility with autorefs' Markdown anchors#651
Conversation
This will be useful for the soon-to-come Markdown anchors feature of mkdocs-autorefs. Related to mkdocs-autorefs#39: mkdocstrings/autorefs#39
Member
Author
|
I first went with a custom iterator approach (yielding parent, index, element) to insert at the right position, but since it iterated forward and we had to insert at Instead, I used a recursive approach, and at each layer I iterate on elements backwards to be able to insert in the being-iterated elements. The other option was to iterate on a copy of the list of elements, but this would have been less efficient. |
pawamoy
commented
Feb 20, 2024
oprypin
reviewed
Feb 21, 2024
Member
|
Looks awesome otherwise :) |
Member
Author
|
OK LGTM! Squashing incoming 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be useful for the soon-to-come Markdown anchors feature of mkdocs-autorefs.
Related to mkdocs-autorefs#39: mkdocstrings/autorefs#39