Fix lack of isolation of Markdown calls from the top-level Markdown#195
Fix lack of isolation of Markdown calls from the top-level Markdown#195pawamoy merged 5 commits intomkdocstrings:masterfrom
Conversation
|
Thanks a lot @oprypin! You're doing great work here 🤩 So, footnotes will now appear only once, but if I understand correctly, one cannot use the same id for different footnotes in different docstrings if one's plan is to render these docstrings in the same page? If yes, I'm OK with that, and we should simply document it! |
|
Also sorry for force-pushing, this is not good practice. |
|
One more thing: I don't think it fixes #193, right? For footnotes we can force different IDs, so I guess for tabs one would need to use different titles if they plan on rendering them in the same page? |
|
You are correct in all regards in your comments. Yes, I'm not handling ID collisions. And actually yes, I'm not sure at all why you force-pushed :D. Do you plan to merge this as a branch, or squash perhaps? |
|
ID collisions are possible to handle by prefixing them, just don't know much hackery that would require. |
|
I rebased to reword the commits 😑 I can be obsessive over little details.
OK, then let's simply document it for now. I'll add a troubleshooting item, merge, and link to the docs in the related issues. Does it sound good? |
Ah I see, didn't catch that. Thanks for the style fix as well. Yes, all good then, no outstanding comments from me. |
Fixes #186
Fixes #192