fix: Do not ignore stderr in case there is a problem in a git call.#416
Merged
pawamoy merged 2 commits intomkdocstrings:mainfrom Sep 25, 2025
Merged
fix: Do not ignore stderr in case there is a problem in a git call.#416pawamoy merged 2 commits intomkdocstrings:mainfrom
pawamoy merged 2 commits intomkdocstrings:mainfrom
Conversation
Previously griffe was only printing the output of stdout in case there was a problem in a git call. This commit implements printing the stderr along with stdout. Issue-415: mkdocstrings#415
pawamoy
requested changes
Sep 24, 2025
Member
pawamoy
left a comment
pawamoy
left a comment
There was a problem hiding this comment.
Thanks! Could we instead redirect stderr to stdout, so that the order of lines emitted by the original command is preserved?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously griffe was only printing the output of stdout in case there was a problem in a git call. This commit implements printing the stderr along with stdout.
Issue-415: #415
For reviewers
Description of the change
Append stderr to stdout in case git call fails.