Fix logo in README#377
Merged
pawamoy merged 1 commit intomkdocstrings:mainfrom Apr 14, 2025
francois-rozet:logo
Merged
Conversation
pawamoy
approved these changes
Apr 14, 2025
Member
pawamoy
left a comment
pawamoy
left a comment
There was a problem hiding this comment.
Thanks so much @francois-rozet! Looks great 🙂 It was bothering me indeed but I didn't take the time to investigate how to improve it, so thank you! And sorry for leaking your email 😅 🙇
Contributor
Author
|
My pleasure, I like this logo a lot so I wanted it to be nicely presented 😄 And no problem about my e-mail, it is already all over the web 😅 |
Member
|
I love the logo too! Thanks again for creating it! 🚀 🚀 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the logo in the README is not displayed properly. This PR fixes it. I also modified the
srcto an absolute path such that it works in PyPI.You can see what it looks like here: https://github.com/francois-rozet/griffe/tree/logo