Thanks a lot for the PR @has2k1!

So, with these changes, Parameters start to look a lot like Objects 🤔 I'm not sure that's something I want. That creates a bit of code duplication. We could reuse mixins to avoid that, but we don't want to go full in and make Parameters actual Objects, because they're not.

I see that you added these attributes/properties:

• docstring
• lineno
• endlineno
• parent
• lines
• linescollections
• source

May I know why not just adding a docstring attribute (and parameter)?

To me, source will not be super useful: most of the time, multiple parameters appear on the same line. Even if we're OK with that, getting the source with these line numbers will most of the time again return code with invalid syntax (because the code will be incomplete, for example providing just the signature of a function, or even just a line of it). This is in contrast to the other objects, where their source property always return valid/complete code. I understand that this PR only gives docstrings to parameters of dataclasses, but since the API is there for any parameter, it must make sense for all of them.

If lineno, endlineno, lines and lines_collection were added to support source, then I think we can just get rid of all of them. I prefer not providing API than providing incorrect one. We can always revise later.

The parent attribute is probably interesting to have, just for navigation purposes (going from parameter to the function above). But then, lets keep things simple for now, and lets avoid giving Parameter too much of the shape of Objects: lets remove the module and filepath properties too. They can be accessed by passing through the parent first.

Finally, I wonder if using actual Docstrings makes sense: I don't think it makes sense to use docstring sections, or a particular docstring style for parameter docstrings? They usually are plain markup strings, no? Then, maybe parameter docstrings should just be strings? Ah, they could use generic admonitions which should be parsed too.

Thanks, it's super clean now :)

Just a few suggestions.

Thanks 🙂 I'll just rename parent to function and I think we're good.