Skip to content

Commit f9e48c1

Browse files
committed
perf: Cache serializable expression fields
1 parent b7de96f commit f9e48c1

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

‎packages/griffelib/src/griffe/_internal/expressions.py‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
from dataclasses import dataclass
2828
from dataclasses import fields as getfields
2929
from enum import IntEnum, auto
30-
from functools import partial
30+
from functools import cache, partial
3131
from typing import TYPE_CHECKING, Any, Protocol
3232

3333
from griffe._internal.agents.nodes.parameters import get_parameters
@@ -157,11 +157,19 @@ def _field_as_dict(
157157
return element
158158

159159

160+
@cache
161+
def _serializable_expression_fields(expression_class: type[Expr]) -> tuple[str, ...]:
162+
return tuple(
163+
field.name
164+
for field in sorted(getfields(expression_class), key=lambda field: field.name)
165+
if field.name != "parent"
166+
)
167+
168+
160169
def _expr_as_dict(expression: Expr, **kwargs: Any) -> dict[str, Any]:
161170
fields = {
162-
field.name: _field_as_dict(getattr(expression, field.name), **kwargs)
163-
for field in sorted(getfields(expression), key=lambda f: f.name)
164-
if field.name != "parent"
171+
field_name: _field_as_dict(getattr(expression, field_name), **kwargs)
172+
for field_name in _serializable_expression_fields(type(expression))
165173
}
166174
fields["cls"] = expression.classname
167175
return fields

0 commit comments

Comments
 (0)