Skip to content

Commit e21851e

Browse files
committed
perf: Maintain map of AST node type to visitor function
1 parent b968de0 commit e21851e

1 file changed

Lines changed: 20 additions & 6 deletions

File tree

  • packages/griffelib/src/griffe/_internal/agents

‎packages/griffelib/src/griffe/_internal/agents/visitor.py‎

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,7 @@
2525
from typing import TYPE_CHECKING, Final
2626

2727
from griffe._internal.agents.nodes.assignments import get_instance_names, get_names
28-
from griffe._internal.agents.nodes.ast import (
29-
ast_children,
30-
ast_kind,
31-
ast_next,
32-
)
28+
from griffe._internal.agents.nodes.ast import ast_children, ast_next
3329
from griffe._internal.agents.nodes.docstrings import get_docstring
3430
from griffe._internal.agents.nodes.exports import safe_get__all__
3531
from griffe._internal.agents.nodes.imports import relative_to_absolute
@@ -63,6 +59,7 @@
6359
)
6460

6561
if TYPE_CHECKING:
62+
from collections.abc import Callable
6663
from pathlib import Path
6764

6865
from griffe._internal.docstrings.parsers import DocstringOptions, DocstringStyle
@@ -290,7 +287,7 @@ def visit(self, node: ast.AST) -> None:
290287
node: The node to visit.
291288
"""
292289
self._visited_nodes.append(node)
293-
getattr(self, f"visit_{ast_kind(node)}", self.generic_visit)(node)
290+
self._visitor.get(type(node), type(self).generic_visit)(self, node)
294291

295292
def generic_visit(self, node: ast.AST) -> None:
296293
"""Extend the base generic visit with extensions.
@@ -793,3 +790,20 @@ def visit_if(self, node: ast.If) -> None:
793790
self.type_guarded = True
794791
self.generic_visit(node)
795792
self.type_guarded = False
793+
794+
_visitor: dict[type[ast.AST], Callable] = { # noqa: RUF012
795+
ast.Module: visit_module,
796+
ast.ClassDef: visit_classdef,
797+
ast.FunctionDef: visit_functiondef,
798+
ast.AsyncFunctionDef: visit_asyncfunctiondef,
799+
ast.Import: visit_import,
800+
ast.ImportFrom: visit_importfrom,
801+
ast.Assign: visit_assign,
802+
ast.AnnAssign: visit_annassign,
803+
ast.AugAssign: visit_augassign,
804+
ast.If: visit_if,
805+
}
806+
807+
# YORE: EOL 3.11: Replace block with line 1.
808+
if sys.version_info >= (3, 12):
809+
_visitor[ast.TypeAlias] = visit_typealias

0 commit comments

Comments
 (0)