Skip to content

Commit 03cae74

Browse files
committed
perf: Avoid iterating many times over function parameters when merging stubs
1 parent d3cf2c4 commit 03cae74

1 file changed

Lines changed: 13 additions & 4 deletions

File tree

  • packages/griffelib/src/griffe/_internal

‎packages/griffelib/src/griffe/_internal/merger.py‎

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
if TYPE_CHECKING:
2929
from collections.abc import Sequence
3030

31-
from griffe._internal.models import Attribute, Class, Function, Module, Object, TypeAlias
31+
from griffe._internal.models import Attribute, Class, Function, Module, Object, Parameter, TypeAlias
3232

3333

3434
def _merge_module_stubs(module: Module, stubs: Module) -> None:
@@ -46,9 +46,12 @@ def _merge_class_stubs(class_: Class, stubs: Class) -> None:
4646

4747
def _merge_function_stubs(function: Function, stubs: Function) -> None:
4848
_merge_stubs_docstring(function, stubs)
49+
parameters: dict[str, Parameter] = {}
50+
for parameter in function.parameters:
51+
parameters.setdefault(parameter.name, parameter)
4952
for parameter in stubs.parameters:
5053
with suppress(KeyError):
51-
function.parameters[parameter.name].annotation = parameter.annotation
54+
parameters[parameter.name].annotation = parameter.annotation
5255
function.returns = stubs.returns
5356
_merge_stubs_type_parameters(function, stubs)
5457

@@ -100,13 +103,19 @@ def _merge_annotations(annotations: Sequence[Expr]) -> Expr | None:
100103

101104
def _merge_overload_annotations(function: Function, overloads: list[Function]) -> None:
102105
function.overloads = overloads
106+
overload_parameters: list[dict[str, Parameter]] = []
107+
for overload in overloads:
108+
parameters: dict[str, Parameter] = {}
109+
for parameter in overload.parameters:
110+
parameters.setdefault(parameter.name, parameter)
111+
overload_parameters.append(parameters)
103112
for parameter in function.parameters:
104113
if parameter.annotation is None:
105114
seen = set()
106115
annotations = []
107-
for overload in overloads:
116+
for parameters in overload_parameters:
108117
with suppress(KeyError):
109-
annotation = overload.parameters[parameter.name].annotation
118+
annotation = parameters[parameter.name].annotation
110119
str_annotation = str(annotation)
111120
if isinstance(annotation, Expr) and str_annotation not in seen:
112121
annotations.append(annotation)

0 commit comments

Comments
 (0)