Add Polish translation for built-in themes#3613
Conversation
|
Thanks for the translations!
That sounds like a reasonable request. |
|
Overall LGTM 👍 Some opinionated comments below, you don't have to implement them ✌️ "Nie znaleziono strony" would be nicer to read. If this is the previous/next page button, you can use the translation for that "Poprzednia strona" etc., as it would be nicer to read. Similar to the example shown in the OP, you could add flavour words to make it nicer to read / more grammatically correct e.g. "przy użyciu pakietu MkDocs" Even though it's correct I feel like "frazę wyszukiwania" would be nicer to read, no need to keep it plural. Unneccessary adjective "żadnych" |
|
Thank you for the feedback!
I added this in 6ff8e57. Hopefully this is OK.
Thanks. I tried to follow your comments, however I left the translations for "Previous" and "Next" in the MkDocs theme as is, because there wasn't much free space in the header. |
oprypin
left a comment
There was a problem hiding this comment.
Nice one!:
Would it be OK to modify footer.html within this PR so that the word "theme" gets added to messages.pot?
Hello, I added
.pofiles with Polish language strings for the two built-in themes.Unfortunately, lunr-languages doesn't support Polish but I think this is out of scope for this pull request.
I also noticed that in the "ReadTheDocs" theme, in the footer the word "theme" is not added as a translatable string:
Therefore it gets translated to:
Would it be OK to modify
footer.htmlwithin this PR so that the word "theme" gets added tomessages.pot?