Add fallback git link for non-provider repos#3435
Merged
oprypin merged 2 commits intomkdocs:masterfrom Oct 25, 2023
sumebrius:rtd-generic-git-link
Merged
Add fallback git link for non-provider repos#3435oprypin merged 2 commits intomkdocs:masterfrom sumebrius:rtd-generic-git-link
oprypin merged 2 commits intomkdocs:masterfrom
sumebrius:rtd-generic-git-link
Conversation
Contributor
|
Hmm the logo literally just says "git".. which may be controversial seeing as it doesn't even have to be a git repo. |
Contributor
Author
|
Yeah, the font-awesome 4.7 set is a little more limited than I was expecting.
|
Contributor
|
Yeah that would be great 👍 |
Contributor
Author
|
Done! |
oprypin
approved these changes
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a repo was defined for the readthedocs theme, but the repo wasn't a predefined provider (GitHub, Bitbucket, or GitLab), no repo link would be rendered.
This adds a fallback generic git repo link.
Fixes #3259