Improve debug output for subclasses of navigation elements#3340
Merged
Improve debug output for subclasses of navigation elements#3340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently rewriting the blog plugin in Material for MkDocs (which is now free as part of the community edition), trying to improve interop with the plugin ecosystem, specifically plugins like awesome-pages or static-i18n. For this, I'm subclassing some of the existing classes. However, when we print
navfor debugging, the names of the subclasses are not taken into account. This PR improves debug output when subclassingPage,LinkorSectionclasses, which is especially useful for understanding navigation structure.In this example,
ArchiveandCategoryare subclasses ofPage: