Conversation
And use attribute access for configs in more places
Expand the situations where logs about broken links are produced, make the logging levels fully configurable
Guess what existing page might have been meant based on the provided link, and mention it in the log message.
pawamoy
approved these changes
Jul 3, 2023
Contributor
pawamoy
left a comment
pawamoy
left a comment
There was a problem hiding this comment.
Looks good to me, though my approval does not have a lot of value: I'm not particularly familiar with the code base.
|
Just FYI, this PR broke at least one plugin, that relied on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1755 and a lot more