SubConfig now catches failures and warnings#2710
Conversation
|
Great, no worries @oprypin ! |
|
Oops, unfortunately this makes a test fail. That makes me think that there are probably unforeseen negative implications from this change, so I'll have to revert it until further investigation. |
|
Indeed, sorry. Sad that the CI was not executed on PR :( . Maybe something to consider in the future ? |
|
Update : I was able to test outside of tox, directly in PyCharm.
Therefore there was an error in the subconfig The fix is now doing its job correctly, showing the error to the user. Now the decision to take with this test is "should the 'extra' config option in the default schema accept any kind of options inside it ?". If the answer is yes, we should probably define a constructor flag in Let me know ! |
|
@smarie If I understand correctly, the |
Fixes #2709