Revert the addition of Abort exception and clean up abort messages#2381
Closed
oprypin wants to merge 1 commit into
Closed
Revert the addition of Abort exception and clean up abort messages#2381oprypin wants to merge 1 commit into
oprypin wants to merge 1 commit into
Conversation
Remove some exit messages that provide no additional information, and for others just make them less "shouty". This changes mostly only recently modified messages that I found to be worse than before.
Contributor
|
I know you don't like those changes, but please stop trying to find reasons to back them out. If there is a genuine bug, then let's fix that bug. Otherwise, please stop wasting my time. |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see no upside to having that exception type, but the downside is that it always requires some message, even when we have nothing additional to say.
I also revert some recently added exclamation marks and fix messages where each word is capitalized.