Workaround Safari bug when zooming to < 100%#1389
Merged
waylan merged 1 commit intomkdocs:masterfrom Jan 21, 2018
Merged
Conversation
yeraydiazdiaz
force-pushed
the
fix-safari-bug
branch
from
79609d3 to
4e0c28b
Compare
yeraydiazdiaz
force-pushed
the
fix-safari-bug
branch
from
4e0c28b to
a42ea69
Compare
Contributor
|
@yeraydiazdiaz thanks for these. We don't really have anyone working on front end stuff right now, so any and all help in the area is much appreciated. |
|
Thanks @yeraydiazdiaz! Did you report this bug to Apple as well (unless already reported)? |
Contributor
Author
waylan
added a commit
to waylan/mkdocs
that referenced
this pull request
Jul 10, 2018
The sidebar was under the left margin of the main content and not clickable. This moves the sidebar to the top so it is accessable. Not sure when this got broken. Maybe mkdocs#1387 or mkdocs#1389 or mkdocs#1395.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1050
Tested on Safari 11.0.2 on Mac OS X Sierra.
Haven't tried with Cinder but I assume it's the same problem, Safari simply ignores the
width: 25%of thecol-md-3and pushes thecol-md-9over it. Overriding the padding and width seems to work without affecting other browsers. It's a fairly hideous workaround but aren't they all.