Add New Formatting option to Creation script#55
Merged
mkafrin merged 4 commits intomkafrin:masterfrom Apr 24, 2022
Merged
Conversation
added 2 commits
April 13, 2022 18:29
Added a new formating option for the creation script that formats for use in a config table rather then individual function calls
Added examples in config and updated formatting
Owner
|
Thanks for the contribution! Been busy today, but will take a look at this tomorrow. |
ItsANoBrainer
approved these changes
Apr 22, 2022
mkafrin
requested changes
Apr 23, 2022
Owner
mkafrin
left a comment
mkafrin
left a comment
There was a problem hiding this comment.
Very sorry, this somehow slipped my mind. I had a few small suggestions, but otherwise looks good!
Changed config variable to ConfigFormatEnabled, Added spaces around '=', removed a a blank line, added newline t end of file
Contributor
Author
|
No worries, I made this for our own server and figured someone else might find it useful. I made the requested edits. |
mkafrin
reviewed
Apr 24, 2022
creation/server/creation.lua
Outdated
| printout = printout .. " vector2(" .. tostring(zone.points[i].x) .. ", " .. tostring(zone.points[i].y) .."),\n" | ||
| else | ||
| printout = printout .. " vector2(" .. tostring(zone.points[i].x) .. ", " .. tostring(zone.points[i].y) ..")\n" | ||
| if Config.ConfigFormat then |
Owner
There was a problem hiding this comment.
This needs to be updated to ConfigFormatEnabled as well (in parseCircle and parseBox too).
Contributor
Author
There was a problem hiding this comment.
Whoops, moved to fast for my own good. Should be good now
ConfigFormat refactored to ConfigFormatEnabled
Owner
|
Just merged in. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new formatting option to the creation script that parses the data to a format for use in a config table, rather then individual create function calls. I also added a config to select if you want the new or standard formatting