pin net-telnet dependency to keep ruby support for < 2.3#665
Merged
mizzy merged 1 commit intomizzy:masterfrom Sep 24, 2018
Conversation
Also added todo comments to come back and remove it at a later date and to pin to a min version of ruby at some point. Signed-off-by: Ben Abrams <[email protected]>
Owner
|
Thanks. |
Owner
|
Released as v2.76.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added todo comments to come back and remove it at a later date and to pin to a min version of ruby at some point.
in version version 0.2.0 they dropped ruby version support for
< 2.3. Pinning to0.1.1allows older setups to keep working and then can then be removed at the time in which the version of ruby this gem supports is declared in a major release.Affects:
I plan on dropping those versions of ruby versions in the next major releases of those gems.
Signed-off-by: Ben Abrams [email protected]