Merged
Conversation
| self.set_server(address, tls, address.host) | ||
| # Establish connection is neccessary. | ||
| if not self.server_conn: | ||
| self.connect() |
Member
There was a problem hiding this comment.
We need to fail if there is an error with the server connection. Just returning False is not an option I think.
Member
Author
There was a problem hiding this comment.
How hard would you want it to fail? Throwing an exception?
Member
There was a problem hiding this comment.
Yes. We should talk about this later or tomorrow, I actually disagree with all changes to http.py. 😇
Kriechi
force-pushed
the
safeguard
branch
2 times, most recently
from
3142b6d to
cb3dfdb
Compare
Member
Author
|
ping @mhils |
mitmproxy/protocol/http.py
Outdated
| # > read (100-n)% of large request | ||
| # > send large request upstream | ||
|
|
||
| if "Http2Layer" in [repr(l) for l in self.layers]: |
Member
There was a problem hiding this comment.
Should we rather check for Http2Exception here?
Member
|
Other than my comment above (and the merge conflict), this looks awesome. 👍 😃 |
Member
Author
|
Done. |
Member
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevent backtrace with lost http2 connections
might fix #1084