Repository navigation
Commit a75bbc3
committed
fix: address review feedback on JoinNode proto round-trip
- Drop `..` in encoder destructure; bind `schema: _` explicitly so any
future field added to `Join` is a compile error here. This is the
shape that allowed apache#22065 to slip through silently.
- Reclassify the new key-length mismatch as a proto_error (malformed
wire input) instead of internal_err, matching the surrounding
decoder pattern.
- Drop redundant execution + row-count checks from
roundtrip_join_null_aware; Debug-equality already covers the
field-preservation regression.
- Rewrite roundtrip_join_null_equality to construct the Join directly
via Join::try_new with NullEquality::NullEqualsNull set at
construction, instead of SQL + optimizer + transform_up mutation.1 parent 5ce8de0 commit a75bbc3
2 files changed
Lines changed: 34 additions & 56 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
850 | 850 | | |
851 | 851 | | |
852 | 852 | | |
853 | | - | |
854 | | - | |
| 853 | + | |
| 854 | + | |
855 | 855 | | |
856 | 856 | | |
857 | | - | |
| 857 | + | |
858 | 858 | | |
859 | 859 | | |
860 | 860 | | |
| |||
1494 | 1494 | | |
1495 | 1495 | | |
1496 | 1496 | | |
1497 | | - | |
| 1497 | + | |
| 1498 | + | |
1498 | 1499 | | |
1499 | 1500 | | |
1500 | 1501 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3212 | 3212 | | |
3213 | 3213 | | |
3214 | 3214 | | |
3215 | | - | |
3216 | | - | |
3217 | | - | |
3218 | | - | |
3219 | | - | |
3220 | | - | |
3221 | | - | |
3222 | | - | |
3223 | | - | |
3224 | | - | |
3225 | | - | |
3226 | | - | |
3227 | | - | |
3228 | | - | |
3229 | | - | |
3230 | | - | |
3231 | | - | |
3232 | | - | |
3233 | | - | |
3234 | 3215 | | |
3235 | 3216 | | |
3236 | 3217 | | |
| |||
3241 | 3222 | | |
3242 | 3223 | | |
3243 | 3224 | | |
3244 | | - | |
3245 | | - | |
| 3225 | + | |
| 3226 | + | |
3246 | 3227 | | |
3247 | 3228 | | |
3248 | | - | |
3249 | | - | |
3250 | | - | |
3251 | | - | |
3252 | | - | |
3253 | | - | |
3254 | | - | |
3255 | | - | |
3256 | | - | |
3257 | | - | |
3258 | | - | |
3259 | | - | |
3260 | | - | |
3261 | | - | |
3262 | | - | |
3263 | | - | |
3264 | | - | |
3265 | | - | |
3266 | 3229 | | |
3267 | | - | |
3268 | | - | |
3269 | | - | |
| 3230 | + | |
| 3231 | + | |
| 3232 | + | |
| 3233 | + | |
| 3234 | + | |
| 3235 | + | |
| 3236 | + | |
| 3237 | + | |
| 3238 | + | |
| 3239 | + | |
| 3240 | + | |
| 3241 | + | |
| 3242 | + | |
3270 | 3243 | | |
3271 | | - | |
3272 | | - | |
3273 | | - | |
3274 | | - | |
3275 | | - | |
3276 | | - | |
3277 | | - | |
3278 | | - | |
3279 | | - | |
3280 | | - | |
| 3244 | + | |
| 3245 | + | |
| 3246 | + | |
| 3247 | + | |
| 3248 | + | |
| 3249 | + | |
| 3250 | + | |
| 3251 | + | |
| 3252 | + | |
| 3253 | + | |
| 3254 | + | |
| 3255 | + | |
| 3256 | + | |
| 3257 | + | |
3281 | 3258 | | |
3282 | 3259 | | |
3283 | 3260 | | |
0 commit comments