Skip to content

Commit a64d469

Browse files
committed
test: add null_equality round-trip regression test (apache#22065)
Verified to fail on the un-patched decoder and pass with the fix.
1 parent 3982ebe commit a64d469

1 file changed

Lines changed: 45 additions & 0 deletions

File tree

‎datafusion/proto/tests/cases/roundtrip_logical_plan.rs‎

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3230,3 +3230,48 @@ async fn roundtrip_join_null_aware() -> Result<()> {
32303230

32313231
Ok(())
32323232
}
3233+
3234+
// Regression test for null_equality round-trip (related to #22065).
3235+
#[tokio::test]
3236+
async fn roundtrip_join_null_equality() -> Result<()> {
3237+
use datafusion_common::NullEquality;
3238+
use datafusion_common::tree_node::{Transformed, TreeNode, TreeNodeRecursion};
3239+
use datafusion_expr::logical_plan::Join;
3240+
3241+
let ctx = SessionContext::new();
3242+
let sql = "
3243+
SELECT t1.a FROM (VALUES (1)) AS t1(a)
3244+
INNER JOIN (VALUES (1)) AS t2(b) ON t1.a = t2.b
3245+
";
3246+
let plan = ctx
3247+
.sql(sql)
3248+
.await?
3249+
.into_optimized_plan()?
3250+
.transform_up(|node| {
3251+
Ok(match node {
3252+
LogicalPlan::Join(j) => Transformed::yes(LogicalPlan::Join(Join {
3253+
null_equality: NullEquality::NullEqualsNull,
3254+
..j
3255+
})),
3256+
other => Transformed::no(other),
3257+
})
3258+
})?
3259+
.data;
3260+
3261+
let bytes = logical_plan_to_bytes(&plan)?;
3262+
let rt = logical_plan_from_bytes(&bytes, &ctx.task_ctx())?;
3263+
assert_eq!(format!("{plan:?}"), format!("{rt:?}"));
3264+
3265+
let mut found = false;
3266+
rt.apply(|n| {
3267+
if let LogicalPlan::Join(j) = n
3268+
&& j.null_equality == NullEquality::NullEqualsNull
3269+
{
3270+
found = true;
3271+
}
3272+
Ok(TreeNodeRecursion::Continue)
3273+
})?;
3274+
assert!(found);
3275+
3276+
Ok(())
3277+
}

0 commit comments

Comments
 (0)