Thanks for the PR. The l10n part looks perfectly fine. But can you explain the reauth issue? Under what circumstances would reauth be added? Does it actually clear the Shibboleth session or just the WP session? What is this a fix for? Thanks.

I clicked logout and went back to the WP login page. The reauth parameter was already in the URL (from WordPress I assume) and was being pulled into the URL in the Shibboleth login link. Clicking "Login with Shibboleth" kept taking me back to the WP login page until I removed the reauth argument.

Ok, I could see how that would happen. I can't see this causing much damage so I'm going to merge it. Logging out still works properly as well?

Yeah, I didn't have any issues logging out (the WP page itself still has
the reauth parameter set). This only modifies the Login with Shibboleth
link.

On Wednesday, June 11, 2014, Michael Yoshitaka Erlewine <
[email protected]> wrote:

Ok, I could see how that would happen. I can't see this causing much
damage so I'm going to merge it. Logging out still works properly as well?

—
Reply to this email directly or view it on GitHub
#5 (comment).

Jonathan Champ
PHP Developer / Information Architect
Distance Education & Learning Technology Applications (DELTA)

Email: [email protected]
Phone: 919.513.0694

North Carolina State University
Campus Box 7113, Venture II, Suite 500
Raleigh, NC 27695