Fix another 'undefined index' notice and html typo#31
Open
HirotoKagotani wants to merge 2 commits intomitcho:masterfrom
Open
Fix another 'undefined index' notice and html typo#31HirotoKagotani wants to merge 2 commits intomitcho:masterfrom
HirotoKagotani wants to merge 2 commits intomitcho:masterfrom
Conversation
jrchamp
approved these changes
Dec 14, 2016
Contributor
jrchamp
left a comment
jrchamp
left a comment
There was a problem hiding this comment.
This is some nice cleanup!
|
Hello, thank you for submitting this patch. I released version 1.8 today to resolve this and other issues and included a shoutout for your patch. I am the new maintainer of the plugin and all further work on the plugin will be done in a new GitHub repository. If you have any further issues, please don't hesitate to report them in the new repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit fixes html typo
</labelto</label>in options-admin.php.The second one checks whether
$shib_headers[*]['managed']is set before use their value.