Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

add support for s390x with go1.7#85

Closed
andrewhsu wants to merge 2 commits intomitchellh:masterfrom
andrewhsu:s390x
Closed

add support for s390x with go1.7#85
andrewhsu wants to merge 2 commits intomitchellh:masterfrom
andrewhsu:s390x

Conversation

@andrewhsu
Copy link

@andrewhsu andrewhsu commented May 6, 2017 •
edited
Loading

Go 1.7 adds support for s390x. This PR changes gox to be able to compile on it.

Tests pass:

$ go test
PASS
ok  	github.com/andrewhsu/gox	0.194s

Example compile using gox specifying s390x

$ gox -osarch=linux/s390x github.com/docker/cli/cmd/docker
Number of parallel builds: 3

-->     linux/s390x: github.com/docker/cli/cmd/docker
$ file docker_linux_s390x 
docker_linux_s390x: ELF 64-bit MSB executable, IBM S/390, version 1 (SYSV), statically linked, not stripped

andrewhsu added 2 commits May 5, 2017 18:01
@andrewhsu
fix test logic
4330a5c 
Signed-off-by: Andrew Hsu <[email protected]>
@andrewhsu
add support for s390x with go1.7
57ec44e 
Signed-off-by: Andrew Hsu <[email protected]>
@andrewhsu andrewhsu mentioned this pull request May 6, 2017
Closed
@dnephin dnephin mentioned this pull request May 12, 2017
Merged
@kbhute-ibm
Copy link

kbhute-ibm commented Jun 5, 2017

+1

The fix even works for me. Could you please tell us by when this PR will get merged to master?

@kbhute-ibm
Copy link

kbhute-ibm commented Jun 9, 2017

Hi Team,

May I know if there is any plan to merge this PR? Thanks in advance.

@kbhute-ibm
Copy link

kbhute-ibm commented Jul 7, 2017

Hi @mitchellh

Could you please tell me if there are any plans to merge this PR?

@mattfarina
Copy link
Collaborator

mattfarina commented Nov 22, 2017

@andrewhsu and @kbhute-ibm I'll take a look at this. It would be great to support more platforms.

@Nayana-ibm
Copy link

Nayana-ibm commented Dec 13, 2017

@mattfarina
I have revised patch as below to support s390x platform:

diff --git a/platform.go b/platform.go
index 89401fc..00cc0f6 100644
--- a/platform.go
+++ b/platform.go
@@ -42,6 +42,7 @@ var (
                "arm64",
                "ppc64",
                "ppc64le",
+               "s390x",
        }

        Platforms_1_0 = []Platform{
@@ -86,6 +87,7 @@ var (
                {"linux", "arm64", false},
                {"linux", "ppc64", false},
                {"linux", "ppc64le", false},
+               {"linux", "s390x", false},
        }...)
 )

Could you please take a look?

@ruflin
Copy link
Contributor

ruflin commented Dec 19, 2017

I think this PR becomes obsolete if #96 is merged?

@Nayana-ibm
Copy link

Nayana-ibm commented Dec 19, 2017

@ruflin Yes. Code changes provided in #96 will cover this PR.

@Nayana-ibm Nayana-ibm mentioned this pull request Feb 26, 2018
Merged
@Nayana-ibm
Copy link

Nayana-ibm commented Feb 26, 2018

Covered by #96

@Nayana-ibm
Copy link

Nayana-ibm commented Feb 26, 2018

Can be closed.

@andrewhsu andrewhsu closed this Feb 26, 2018
@andrewhsu andrewhsu deleted the s390x branch February 26, 2018 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andrewhsu @kbhute-ibm @mattfarina @Nayana-ibm @ruflin