Repository navigation
Commit 504bcfc
fix(otel): relax semantic-conventions upper bound (#605)
The `<0.61` cap pinned the whole OpenTelemetry stack for downstream
consumers, not just semconv. OTel ships semconv and the instrumentation
packages as a lockstep set pinned with `==`, and semconv itself requires
an exact opentelemetry-api version, so the ceiling held consumers' api
and sdk at the 1.39.x generation.
Replace the ceiling with a floor on semantic-conventions and
instrumentation-httpx. All 39 semconv symbols the SDK references resolve
to identical values in 0.60b1 and 0.65b0, so no span attribute names
change.
Lifting the cap surfaced a latent bug. W3C trace-context level 2 adds the
random-trace-id flag (0x02), so a sampled span serializes as "-03" from
opentelemetry-api 1.44.0. TraceparentInjectionHook compared the flags byte
with `endswith("-01")`, read that as unsampled, and discarded the
propagated context, starting a new trace on every workflow /execute call.
Test the sampled bit as a bitmask instead.
Verified on semconv 0.60b1 / api 1.39.1 and semconv 0.65b0 / api 1.44.0.
Generated by Mistral Vibe.
Co-authored-by: Mistral Vibe <[email protected]>1 parent 1cc2d2c commit 504bcfc
3 files changed
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
15 | 28 | | |
16 | 29 | | |
17 | 30 | | |
| |||
29 | 42 | | |
30 | 43 | | |
31 | 44 | | |
32 | | - | |
| 45 | + | |
33 | 46 | | |
34 | 47 | | |
35 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
0 commit comments