Fixed Unexpected 'NUMBER'#880
Merged
mistic100 merged 1 commit intomistic100:devfrom Feb 10, 2021
average-web-dev:dev
Merged
Conversation
if you had a query with an "IN" with 10 elements or more, the regex of setRulesFromSQL did not match correctly
Contributor
Author
|
Hey, I think there's something wrong with the build logic |
Owner
|
@MinePlay96 can you give more details on what case this is supposed to fix ? Also add or edit the unit tests (although they don't work on the CI). |
Contributor
Author
$('#queryBuilder').queryBuilder('setRulesFromSQL', {
"sql":"Status IN(:Status_1, :Status_2, :Status_3, :Status_4, :Status_5, :Status_6, :Status_7, :Status_8, :Status_9, :Status_10)",
"params":{
"Status_1":1,
"Status_2":2,
"Status_3":4,
"Status_4":5,
"Status_5":6,
"Status_6":9,
"Status_7":10,
"Status_8":11,
"Status_9":12,
"Status_10":13
}
}, 'named');which would produce the following regex without my adjustments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you had a query with an "IN" with 10 elements or more, the regex of setRulesFromSQL did not match correctly
Merge request checklist
devand I am issuing the PR todevdistdirectory__localeand__authorfields