Fix filter-description plugin not showing button for 'bootbox' option#565
Merged
mistic100 merged 1 commit intomistic100:devfrom Sep 21, 2017
Merged
Fix filter-description plugin not showing button for 'bootbox' option#565mistic100 merged 1 commit intomistic100:devfrom
mistic100 merged 1 commit intomistic100:devfrom
Conversation
The 'bootbox' option for the 'filter-description' plugin failed to re-show the button, once hidden. In my case, I selected a filter with a description field, pressed the down arrow key to select the next filter in the dropdown, which did not contain a description. I then pressed up arrow key to return to the previous filter with a description, but this time it did now show the filter-description button. I fixed the code to match the convention of the 'inline' and 'popover' options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'bootbox' option for the 'filter-description' plugin failed to re-show the button, once hidden.
In my case, I selected a filter with a description field, pressed the down arrow key to select the next filter in the dropdown, which did not contain a description. I then pressed up arrow key to return to the previous filter with a description, but this time it did now show the filter-description button.
I fixed the code to match the convention of the 'inline' and 'popover' options.