Skip to content
This repository was archived by the owner on Jul 15, 2024. It is now read-only.

feat: add type of gallery#55

Merged
syuilo merged 9 commits intomisskey-dev:developfrom
ryohidaka:typed-gallery
Feb 10, 2023
Merged

feat: add type of gallery#55
syuilo merged 9 commits intomisskey-dev:developfrom
ryohidaka:typed-gallery

Conversation

@ryohidaka
Copy link
Contributor

@ryohidaka ryohidaka commented Feb 9, 2023

Closes #54

What

Why

  • ギャラリー系は現状の型指定がanyで、正確な型判定ができないため修正しました。
  • The current type specification is any, which does not allow accurate type determination. So I fixed it.

Additional info (optional)

  • コード全体に対してlinterを実行したところ差分が多くなりました。そのため、自分が対応した範囲のみで実行しています。

  • I ran the linter on the entire code and there were a lot of differences. Therefore, I am running it only on the area that I have addressed.

  • コミット数が多いので、問題なければSquash and mergeしてください。

  • If there are too many commits, please Squash and merge if there is no problem.

@syuilo syuilo merged commit 13a2d16 into misskey-dev:develop Feb 10, 2023
@syuilo
Copy link
Member

syuilo commented Feb 10, 2023

ありがとうございます👍

@ryohidaka ryohidaka deleted the typed-gallery branch February 12, 2023 06:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gallery系の型定義を追記する

2 participants