fix(locales): "Show More"の日本語訳を修正#11073
Closed
ryohidaka wants to merge 1 commit intomisskey-dev:l10n_developfrom
ryohidaka:fix/showmore-ja
Closed
fix(locales): "Show More"の日本語訳を修正#11073ryohidaka wants to merge 1 commit intomisskey-dev:l10n_developfrom ryohidaka:fix/showmore-ja
ryohidaka wants to merge 1 commit intomisskey-dev:l10n_developfrom
ryohidaka:fix/showmore-ja
Conversation
Codecov Report
@@ Coverage Diff @@
## l10n_develop #11073 +/- ##
================================================
+ Coverage 69.14% 77.37% +8.22%
================================================
Files 706 908 +202
Lines 65339 91292 +25953
Branches 5186 6842 +1656
================================================
+ Hits 45179 70637 +25458
- Misses 20160 20655 +495 |
Member
|
基本的にローカリゼーションはMisskeyのドメイン知識に依存しない方がよく、そうするとShow moreの訳として「もっと見る」は正しい |
Member
|
なので他の解決方法を探す必要があるためこちらはCloseします🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10747
What
以下のIssueのフォローアップです。
Why
Issueとして上がっていたため
Additional info (optional)
内容としてはローカライゼーションに当たると思われるので、ターゲットブランチを
l10n_developにしています。関西弁(
ja-KS)に関しては、現状どちらもまだまだあるで！となっておりますが、代案が思いつかなかったのでそちらは変更していません。CHANGELOG.mdも更新していませんが、必要でしたら更新分をコミットするので、コメント等で教えてください。Checklist