Skip to content

Add .gitattributes to checkout lf eol style#1487

Closed
avdg wants to merge 1 commit into
mishoo:masterfrom
avdg:gitattributes
Closed

Add .gitattributes to checkout lf eol style#1487
avdg wants to merge 1 commit into
mishoo:masterfrom
avdg:gitattributes

Conversation

@avdg

@avdg avdg commented Feb 11, 2017

Copy link
Copy Markdown
Contributor

No description provided.

This was referenced Feb 11, 2017
@alexlamsl

Copy link
Copy Markdown
Collaborator

I just switched from master and back, and noticed test/compress/drop-console.js also suffers from the CRLF issue.

@avdg

avdg commented Feb 12, 2017

Copy link
Copy Markdown
Contributor Author

ow :/

@avdg

avdg commented Feb 12, 2017

Copy link
Copy Markdown
Contributor Author

git grep doesn't help me a lot, it lists a lot of files if I look for \r

@avdg

avdg commented Feb 12, 2017

Copy link
Copy Markdown
Contributor Author

hmm had to test this on c9

$ git grep -Il $'\r'
test/compress/dead-code.js
test/compress/drop-console.js

@avdg

avdg commented Feb 12, 2017

Copy link
Copy Markdown
Contributor Author

Pushed fix

@alexlamsl

Copy link
Copy Markdown
Collaborator

Here's a quick browse using Visual Studio Code for CRLF files:

test/compress/dead-code.js
test/compress/drop-console.js

So I think we are covered 👍

alexlamsl pushed a commit to alexlamsl/UglifyJS that referenced this pull request Feb 18, 2017
@alexlamsl alexlamsl closed this in c06a50f Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants