fix corner case in collapse_vars (#5505)

alexlamsl · web-flow · commit 053cb27fe33e · 2022-06-10T09:12:59.000+08:00
fixes #5504
diff --git a/lib/compress.js b/lib/compress.js
@@ -2356,7 +2356,7 @@ Compressor.prototype.compress = function(node) {
                         if (prop.key instanceof AST_Node) prop.key = prop.key.transform(tt);
                         if (prop.static) {
                             if (prop instanceof AST_ClassField) {
-                                props.push(prop);
+                                if (prop.value) props.push(prop);
                             } else if (prop instanceof AST_ClassInit) {
                                 props.unshift(prop);
                             }
diff --git a/test/compress/classes.js b/test/compress/classes.js
@@ -3179,3 +3179,25 @@ issue_5502: {
     expect_stdout: "PASS 42"
     node_version: ">=12"
 }
+
+issue_5504: {
+    options = {
+        collapse_vars: true,
+    }
+    input: {
+        "use strict";
+        var a;
+        console.log((a = 42, class {
+            static p;
+        }).p);
+    }
+    expect: {
+        "use strict";
+        var a;
+        console.log((a = 42, class {
+            static p;
+        }).p);
+    }
+    expect_stdout: "undefined"
+    node_version: ">=12"
+}

Original file line number	Diff line number	Diff line change
`@@ -2356,7 +2356,7 @@ Compressor.prototype.compress = function(node) {`
`2356`	`2356`	`if (prop.key instanceof AST_Node) prop.key = prop.key.transform(tt);`
`2357`	`2357`	`if (prop.static) {`
`2358`	`2358`	`if (prop instanceof AST_ClassField) {`
`2359`		`- props.push(prop);`
	`2359`	`+ if (prop.value) props.push(prop);`
`2360`	`2360`	`} else if (prop instanceof AST_ClassInit) {`
`2361`	`2361`	`props.unshift(prop);`
`2362`	`2362`	`}`