contributor api binding#114
Merged
dsheets merged 1 commit intomirage:masterfrom May 23, 2016
sevenEng:contributor_api
Merged
Conversation
Member
|
I've restarted the failed TravisCI build. Not sure why camomille failed on Windows.. |
Member
|
Camomile is still failing on Windows. I will merge this anyway. Thanks, Qi Li, this is a nice contribution and really helps. I have a few nitpicks but I will address them in a subsequent PR. |
This was referenced May 24, 2016
Closed
Closed
Contributor
Author
|
Glad I can help : ) Thanks for merging 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
try to solving issue #112
according to the github doc https://developer.github.com/v3/repos/statistics/#get-contributors-list-with-additions-deletions-and-commit-counts, request would be responded with 202 (and empty body) when the contributor data need to be calculated and haven't been cached, under this situation, return an empty list
omitted some fields in the response, suggestions welcome : )