manifest support for per-monitor high DPI support#1339
Conversation
|
Per-monitor support was added to the code 10 years ago and seems to be working. |
|
Also, see function set_per_monitor_dpi_aware in winmain.c: This comment suggests that extending the manifest may impact mintty at runtime, so this change needs thorough testing. As I have only one monitor, I would like to ask you to do such testing and confirm everything works fine with the change. Additional question: the API also has function SetThreadDpiAwarenessContext which is also used by mintty - how is that related? |
|
Yet another question: |
Those are fallback settings for older versions of Windows in case they don't support the newer high DPI settings |
|
Thanks for considering one of my questions. I did not mean to discourage the change or urge you to close it. |
Also, according to https://learn.microsoft.com/en-us/windows/win32/hidpi/setting-the-default-dpi-awareness-for-a-process, the manifest approach is recommended |
|
OK, but does it interact with an API handling of DPI changes? |
Funny; I don't have a second monitor to test this either! But after applying my changes, DPI scaling works (tested at 200% scaling) |
|
Thanks so far. The most delicate question I have in mind is the test case to move a window between two monitors with different DPI setting. This should be tested by someone before committing this change which otherwise looks fine. |
|
I've tested this in Virtualbox with 2 virtual monitors. Merging, thank you. |
|
Released 3.8.2. |
No description provided.